Abstract models containing ImageSpecFields are not handled properly #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my models is abstract and includes several
ImageSpecField
fields. Calling./manage.py generateimages
leads to an exception inimagekit/specs/sourcegroups.py
at the line:The attached commit fixes this particular exception, but I don't think it addresses all the potential issues involved with abstract base classes. For example, the generator registry only includes one entry corresponding to the abstract base; it may make sense to instead list it for all the descendants that correspond to non-abstract models.