Treat "an"s equal to "a"s #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
commented
Jan 30, 2021
| @@ -101,7 +103,7 @@ def test_compatability | |||
| assert_equal '1/2', Numerizer.numerize('1/2') | |||
| assert_equal '05/06', Numerizer.numerize('05/06') | |||
| assert_equal "3.5 hours", Numerizer.numerize("three and a half hours") | |||
| assert_equal "1/2 an hour", Numerizer.numerize("half an hour") | |||
| assert_equal "1/2 1 hour", Numerizer.numerize("half an hour") | |||
There was a problem hiding this comment.
@jduff this might be an unintentional consequence of this change.
There was a problem hiding this comment.
hm, I don't really like that this changes, a fraction next to 1 is kind of weird. Can you look into it and see if there's a way to make this work without it affecting this test?
There was a problem hiding this comment.
To be honest, this problem existed earlier with "a".
assert_equal "1/2 a kilo", Numerizer.numerize("half a kilo")
jduff
requested changes
Feb 8, 2021
| @@ -101,7 +103,7 @@ def test_compatability | |||
| assert_equal '1/2', Numerizer.numerize('1/2') | |||
| assert_equal '05/06', Numerizer.numerize('05/06') | |||
| assert_equal "3.5 hours", Numerizer.numerize("three and a half hours") | |||
| assert_equal "1/2 an hour", Numerizer.numerize("half an hour") | |||
| assert_equal "1/2 1 hour", Numerizer.numerize("half an hour") | |||
There was a problem hiding this comment.
hm, I don't really like that this changes, a fraction next to 1 is kind of weird. Can you look into it and see if there's a way to make this work without it affecting this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
n?to all occurrences of "a" so that "an" is also processed equivalently.Fixes #19.