Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak Python 2.6 after version 0.13.0? #62

Closed
xZise opened this issue Sep 21, 2015 · 5 comments
Closed

Unbreak Python 2.6 after version 0.13.0? #62

xZise opened this issue Sep 21, 2015 · 5 comments

Comments

@xZise
Copy link

xZise commented Sep 21, 2015

pywikibot-core is currently using unicodecsv on Python 2.7 and 2.6 and removing support for Python 2.6 broke support. Now it's not that much of a problem as users could install an older version. But I wanted to ask whether you are interested in supporting 2.6 again by using OrderedDict from a third party library like ordereddict or future. If you want I could work on a pull request, but there still seem to be a lot of Python 2.6 users especially those using Redhat Linux.

Now if you are not interested you can just close this bug and we're going to limit the version to 0.13.0 on Python 2.6.

@ryanhiebert
Copy link
Collaborator

2.6 is supported again, via reverting that change that required OrderedDict.

@jdunck
Copy link
Owner

jdunck commented Sep 23, 2015

@xZise is it reasonable to upgrade to 0.14.1?

@xZise
Copy link
Author

xZise commented Sep 23, 2015

I hope you didn't revert because of us ;) Anyway if only 0.14.0 does not support Python 2.6 we can forbid only 0.14.0 on it so that new users will install the most recent version. I've done that in xZise/pywikibot-core@fe12b56 and currently let it run our tests on https://travis-ci.org/xZise/pywikibot-core/builds/81838549

It's not merged into the repository yet as I'm waiting for the results of these tests. Not sure what you mean with upgrade to 0.14.1 (if you mean something else) as we can't bring the users to install a the most recent version unless they install it with my new definition of course.

@ryanhiebert
Copy link
Collaborator

@xZise: Since 0.14.0 breaks your software, you'll need to note that it isn't compatible. It sounds like that's you're method. Are you satisfied to close this issue, then?

@xZise
Copy link
Author

xZise commented Oct 17, 2015

Okay 0.14.1 is now installed so it should be fine. Users who have 0.14.0 installed on Python 2.6 will get an error when they try to insta Pywikibot. I think that enough (apart from the fact that the user installed an invalid version beforehand).

@xZise xZise closed this as completed Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants