Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you take a PR to replace JSDom with parse5? #4

Closed
bennypowers opened this issue Dec 15, 2020 · 2 comments
Closed

Would you take a PR to replace JSDom with parse5? #4

bennypowers opened this issue Dec 15, 2020 · 2 comments

Comments

@bennypowers
Copy link
Contributor

Howdy

I put together an alternate implementation that uses parse5 and hast instead of JSDom, and is quite performant.

Rather than publish under some other name, would you be interested in taking a PR?
@jdvivar
Copy link
Owner

jdvivar commented Dec 15, 2020

Hi Benny! I know and follow you on Twitter!

Of course!

By the way I did this a bit in a whim, if you find any other way to improve it, please tell

This was referenced Dec 22, 2020
Open
Merged
@jdvivar
Copy link
Owner

jdvivar commented Dec 26, 2020

Closing as it's merged now, see #5

@jdvivar jdvivar closed this as completed Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdvivar @bennypowers