Deal with permalink: false

[bennypowers]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch eleventy-plugin-add-web-component-definitions@2.0.1 for the project I'm working on because templates with permalink: false cause an error when running the package.

Here is the diff that solved my problem:

diff --git a/node_modules/eleventy-plugin-add-web-component-definitions/add-web-component-definitions.js b/node_modules/eleventy-plugin-add-web-component-definitions/add-web-component-definitions.js
index 2fbc2d6..da3ac31 100644
--- a/node_modules/eleventy-plugin-add-web-component-definitions/add-web-component-definitions.js
+++ b/node_modules/eleventy-plugin-add-web-component-definitions/add-web-component-definitions.js
@@ -16,6 +16,9 @@ const addChild = (body, child, position) => {
 }
 
 module.exports = function (options, content, outputPath) {
+  if (typeof outputPath !== 'string')
+    return content;
+    
   if (!!options.path && !!options.specifiers) {
     throw new Error('You may configure a path function or import specifiers, but not both')
   }

This issue body was partially generated by patch-package.

[jdvivar]

What a great tool is patch-package! I didn't know it until now 😀
Fixing it 🛠

[jdvivar]

@bennypowers
What if your permalink actually doesn't end with html?

In the demo:

---
permalink: "whatever"
---
<custom-tag></custom-tag>

I also asked in 11ty/eleventy#653

[bennypowers]

What a great tool is patch-package! I didn't know it until now 😀
Fixing it 🛠

I know, right?

What if your permalink actually doesn't end with html?

I dunno, really, but maybe that's a separate issue?

[jdvivar]

I think I've found a good balance, tell me if it works well for you in your projects