Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS > 2.304 Breaks Bluebird Promisify in NPM-Register #143

Closed
dgautsch opened this issue Oct 22, 2018 · 4 comments
Closed

AWS > 2.304 Breaks Bluebird Promisify in NPM-Register #143

dgautsch opened this issue Oct 22, 2018 · 4 comments
Labels
bug

Comments

@dgautsch
Copy link
Collaborator

See: aws/aws-sdk-js#2229
@canercandan
Copy link

the issue #135 is also related, and I finally managed to fix it by setting this dependency with a fixed version:

"aws-sdk": "2.227.1"

@dgautsch dgautsch mentioned this issue Oct 22, 2018
Merged
@dgautsch dgautsch added the bug label Oct 22, 2018
@dgautsch
Copy link
Collaborator Author

dgautsch commented Oct 22, 2018 •
edited

@canercandan yea I see the issue now. Because we have the flag to update minor versions. It's a little annoying that AWS-sdk implemented a breaking change like that. I'll have to republish with a fixed version. Thanks for your patience.

CircleCI probably would've caught this if it had been working. I only recently got that situated.

@dgautsch dgautsch mentioned this issue Oct 22, 2018
Open
@dgautsch
Copy link
Collaborator Author

@canercandan I published v2.8.2 on npm. This should be compatible with s3

@canercandan
Copy link

@dgautsch awesome thanks for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgautsch @canercandan