Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: only warn if build tool cannot update #1212

Merged
merged 1 commit into from
Dec 19, 2023
Merged

ruby: only warn if build tool cannot update #1212

merged 1 commit into from
Dec 19, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 19, 2023

Fixes #1211

@jdx jdx enabled auto-merge (squash) December 19, 2023 19:33
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7dc6c92) 82.58% compared to head (c4807e2) 82.54%.

Files Patch % Lines
src/plugins/core/ruby.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   82.58%   82.54%   -0.04%     
==========================================
  Files         141      141              
  Lines       13122    13128       +6     
==========================================
  Hits        10837    10837              
- Misses       2285     2291       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.13s
✅ BASH bash-exec 20 0 0.06s
✅ BASH shellcheck 20 0 0.47s
✅ BASH shfmt 20 0 0 0.03s
✅ DOCKERFILE hadolint 7 0 0.27s
✅ EDITORCONFIG editorconfig-checker 453 0 0.42s
✅ JSON eslint-plugin-jsonc 7 0 0 1.02s
✅ JSON jsonlint 6 0 0.13s
✅ JSON prettier 7 0 0 0.64s
✅ JSON v8r 7 0 4.22s
✅ MARKDOWN markdownlint 13 0 0 2.77s
✅ MARKDOWN markdown-link-check 13 0 12.81s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.41s
✅ PYTHON bandit 1 0 0.68s
✅ PYTHON black 1 0 0 0.55s
✅ PYTHON flake8 1 0 0.34s
✅ PYTHON isort 1 0 0 0.32s
✅ PYTHON mypy 1 0 2.01s
✅ PYTHON pylint 1 0 1.31s
✅ PYTHON pyright 1 0 5.36s
✅ PYTHON ruff 1 0 0 0.05s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.12s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 2.21s
✅ REPOSITORY syft yes no 0.48s
✅ REPOSITORY trivy-sbom yes no 0.99s
✅ REPOSITORY trufflehog yes no 4.46s
✅ RUBY rubocop 2 0 0 4.88s
✅ RUST clippy yes no 108.65s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 13 0 0 1.16s
✅ YAML v8r 13 0 12.8s
✅ YAML yamllint 13 0 0.37s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@jdx jdx merged commit eb69c35 into main Dec 19, 2023
6 of 8 checks passed
@jdx jdx deleted the warn-on-ruby-build branch December 19, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating ruby-build throws error but should warn
1 participant