Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix order of env and path when using multiple versions #170

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

jdx
Copy link
Owner

@jdx jdx commented Feb 21, 2023

this also reversed the order of tool-versions so now it will export PATH that is equivalent to the tool-versions file.

e.g.: this tool-versions:

nodejs 18
python 3.11

will export:

PATH="~/.rtx/installs/node/18/bin:~/.rtx/installs/python/3.11/bin"

this shouldn't matter in nearly any case but it should fit more what people expect

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 82.09% // Head: 82.09% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1b706ce) compared to base (12d0257).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1b706ce differs from pull request most recent head c184da9. Consider uploading reports for the commit c184da9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   82.09%   82.09%   -0.01%     
==========================================
  Files          90       90              
  Lines        2860     2859       -1     
==========================================
- Hits         2348     2347       -1     
  Misses        512      512              
Impacted Files Coverage Δ
src/cli/env.rs 100.00% <ø> (ø)
src/cli/local.rs 76.92% <ø> (ø)
src/cli/mod.rs 87.69% <ø> (ø)
src/toolset/mod.rs 88.27% <100.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx jdx merged commit a801565 into main Feb 21, 2023
@jdx jdx deleted the path-order branch February 21, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant