Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for PATH in .rtx.toml env vars #313

Merged
merged 1 commit into from
Mar 12, 2023
Merged

feat: support for PATH in .rtx.toml env vars #313

merged 1 commit into from
Mar 12, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Mar 12, 2023

This makes it so you can add new directories to PATH in .rtx.toml. This is done by specifying PATH as an array like the following:

[env]
PATH = [
  "/foo",  # absolute path
  "./bar", # relative to the directory .rtx.toml is in
  "$PATH" # for now this is required to be at the end
]

This makes it so you can add new directories to PATH in .rtx.toml. This
is done by specifying PATH as an array like the following:

```toml
[env]
PATH = [
  "/foo"  # absolute path
  "./bar" # relative to the directory .rtx.toml is in
  "$PATH" # for now this is required to be at the end
]
```
@jdx jdx enabled auto-merge (squash) March 12, 2023 21:33
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 93.24% and project coverage change: +0.02 🎉

Comparison is base (a74ff74) 88.32% compared to head (cea77f2) 88.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   88.32%   88.34%   +0.02%     
==========================================
  Files         100      100              
  Lines        8074     8145      +71     
==========================================
+ Hits         7131     7196      +65     
- Misses        943      949       +6     
Impacted Files Coverage Δ
src/config/config_file/mod.rs 94.00% <ø> (ø)
src/config/config_file/rtx_toml.rs 84.42% <91.52%> (+0.78%) ⬆️
src/config/config_file/legacy_version.rs 56.14% <100.00%> (+2.43%) ⬆️
src/config/config_file/tool_versions.rs 99.41% <100.00%> (+0.01%) ⬆️
src/config/mod.rs 84.43% <100.00%> (+0.32%) ⬆️
src/toolset/mod.rs 75.46% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx jdx merged commit b3bbf5e into main Mar 12, 2023
@jdx jdx deleted the path-env branch March 12, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant