Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates, security fixes, and performance optimizations #137

Merged
merged 12 commits into from Oct 21, 2018

Conversation

dgautsch
Copy link
Collaborator

@dgautsch dgautsch commented Oct 20, 2018

Changes

  • Upgrading out of date packages and security vulnerabilities
  • Changing minifier for webpack to terser.
  • Fixed package unit tests failing when redis unavailable
  • adding a package-lock file

@dgautsch dgautsch added the WIP label Oct 20, 2018
@dgautsch dgautsch requested a review from jdx October 20, 2018 03:10
@dgautsch dgautsch added this to the v2.8.2 milestone Oct 20, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #137 into master will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #137      +/-   ##
=========================================
+ Coverage   85.98%   86.9%   +0.91%     
=========================================
  Files          30      29       -1     
  Lines         521     481      -40     
=========================================
- Hits          448     418      -30     
+ Misses         73      63      -10
Impacted Files Coverage Δ
lib/storage/s3.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d2c3d...74c9498. Read the comment docs.

@dgautsch dgautsch self-assigned this Oct 20, 2018
@dgautsch dgautsch removed the WIP label Oct 21, 2018
@dgautsch dgautsch changed the title WIP | Update packages and broken tests Update packages and broken tests Oct 21, 2018
@dgautsch dgautsch changed the title Update packages and broken tests Package updates, security fixes, and performance optimizations Oct 21, 2018
@dgautsch dgautsch merged commit 0377742 into jdx:master Oct 21, 2018
@dgautsch dgautsch deleted the fix/npm-audit-fix branch October 24, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant