Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify roles of the two implementations #2

Closed
ColinH opened this issue Aug 6, 2018 · 2 comments
Closed

Clarify roles of the two implementations #2

ColinH opened this issue Aug 6, 2018 · 2 comments

Comments

@ColinH
Copy link

ColinH commented Aug 6, 2018

Just found this library and am quite surprised by how much of a performance improvement it made for our project!

However, while the interface of the functions is indeed so simple as to be mostly self explanatory, I am unsure about the roles of itoa_jeaiii.cpp and to_chars.cpp, i.e. which one to choose when, seeing that they basically offer the same functionality...

Thanks!

@jeaiii
Copy link
Owner

jeaiii commented Aug 8, 2018

Awesome, glad it helped!

The api for itoa_jeaiii.cpp matches that used by the benchmark project and assumes a big enough input buffer like the non-standard itoa() function. to_chars.cpp is written to make implementing std::to_chars easy and has a safer api. to_chars.cpp is the one to use if you want future improvements.

@ColinH
Copy link
Author

ColinH commented Aug 9, 2018

Thanks, then, for now, we used the more appropriate version, though it required a couple of changes to be integrated into our header-only C++ library.

@ColinH ColinH closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants