New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't think `n` can ever be < 10 here #8

Closed

jeaiii opened this issue Jul 18, 2022 · 0 comments

Owner

jeaiii commented Jul 18, 2022

itoa/include/itoa/jeaiii_to_text.h

Line 150 in 84f25b8

b = n < 10 ? b + 1 : b + 2;

all 9 digits numbers should be handled above (and ~4/10ths of the 10 digits numbers) so this should be like:

itoa/include/itoa/jeaiii_to_text.h

Lines 209 to 213 in 84f25b8

    
           if (n < u32(1e2)) 
        
           { 
        
               *reinterpret_cast<pair*>(b) = digits.dd[n]; 
        
               b += 2; 
        
           }

jeaiii closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment