Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CreateRef<T> and CreateWeakRef<T> to use IntrusivePtr #285

Closed
JeanPhilippeKernel opened this issue Nov 29, 2023 · 0 comments · Fixed by #286
Closed

Update CreateRef<T> and CreateWeakRef<T> to use IntrusivePtr #285

JeanPhilippeKernel opened this issue Nov 29, 2023 · 0 comments · Fixed by #286
Assignees
@JeanPhilippeKernel
Labels
critical enhancement New feature or request
Milestone
Born baby (0.2.0)

Comments

@JeanPhilippeKernel
Copy link
Owner

JeanPhilippeKernel commented Nov 29, 2023 •
edited
Loading

Since we now have IntrusivePtr in the house - thanks to @jnyfah for this awesome work - We need to migrate existing code to widely consume it.

CreateRef and CreateWeakRef are the right first candidates to start the changes
@JeanPhilippeKernel JeanPhilippeKernel added enhancement New feature or request good first issue Good for newcomers labels Nov 29, 2023
@JeanPhilippeKernel JeanPhilippeKernel added this to the Born baby (0.2.0) milestone Nov 29, 2023
@JeanPhilippeKernel JeanPhilippeKernel self-assigned this Nov 29, 2023
@JeanPhilippeKernel JeanPhilippeKernel added critical and removed good first issue Good for newcomers labels Nov 30, 2023
@JeanPhilippeKernel JeanPhilippeKernel linked a pull request Nov 30, 2023 that will close this issue
spread the use of IntrusivePtr #286
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeanPhilippeKernel JeanPhilippeKernel

Labels
critical enhancement New feature or request
Projects
ZEngine Board
Status: Done
Milestone
Born baby (0.2.0)
Development

Successfully merging a pull request may close this issue.

spread the use of IntrusivePtr JeanPhilippeKernel/RendererEngine
1 participant
@JeanPhilippeKernel