Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyness behaviour on vertical vs horizontal mode #10

Closed
davidcedresx opened this issue Jul 13, 2021 · 3 comments · Fixed by #11
Closed

Lazyness behaviour on vertical vs horizontal mode #10

davidcedresx opened this issue Jul 13, 2021 · 3 comments · Fixed by #11

Comments

@davidcedresx
Copy link

davidcedresx commented Jul 13, 2021

Hi, thank you for such a great component I truly love it.

I have been using it on my desktop just fine, right now I am putting some focus on responsiveness and I found that the stepper will become vertical by default which is great, the issue is that every render function for every step triggers immediately, on the horizontal mode they just trigger when you reach that step.

Sandbox which replicates the issue:
https://codesandbox.io/s/sharp-johnson-l4qyk?file=/src/Test.js

@jeanverster
Copy link
Owner

Hi @davidcedresx - thanks for pointing this out, will try have a look asap 👌🏼

@jeanverster
Copy link
Owner

hey @davidcedresx I've updated the behaviour to only mount the content component when the step is active, I believe this this is the desired behaviour. Will create a release with this update soon. It just occurred to me that it could be nice to have this lazy behaviour controlled by a prop 😅 Think I will add this in too at some stage

@jeanverster
Copy link
Owner

Available in 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants