Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making libdht #22

Closed
nschloe opened this issue Dec 20, 2016 · 2 comments
Closed

making libdht #22

nschloe opened this issue Dec 20, 2016 · 2 comments

Comments

@nschloe
Copy link

nschloe commented Dec 20, 2016

I came across this working on the Debian integration of transmission. There's the option of using a system DHT library instead of bundling it, but if I see correctly, dht can't build as a library yet. I don't know why not, given that dht is so useful.

I could create a PR that add that, if you'd like.

@jech
Copy link
Owner

jech commented Jan 1, 2017

No, please link statically. There are no ABI guarantees for this piece of code, it's meant to be bundled.

@nschloe
Copy link
Author

nschloe commented Jan 2, 2017

Instead of "link statically", I guess you mean bundle. Building a static library and actually linking that be would be far more superior to this approach IMO, and ABI changes could be handled by version bumps. Anyways, closing since there's no interest in this on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants