Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font: inherit - scales/font-family - crash #36

Closed
digitaljohn opened this issue Apr 17, 2020 · 0 comments · Fixed by #40
Closed

font: inherit - scales/font-family - crash #36

digitaljohn opened this issue Apr 17, 2020 · 0 comments · Fixed by #40
Assignees
Labels
bug Something isn't working

Comments

@digitaljohn
Copy link

The font-family rule breaks when using font: inherit;.

Which rule, if any, is the bug related to?

scales/font-family

What CSS is needed to reproduce the bug?

a {
  font: inherit;
}

What stylelint configuration is needed to reproduce the bug?

e.g.

{
  "rules": {
    "scales/font-family": [
      ["XXX", "sans-serif"]
    ]
  }
}

Which version of stylelint are you using?

e.g. 13.2.1

Which version of stylelint-scales are you using?

e.g. 1.2.0

How are you running stylelint: CLI, PostCSS plugin, Node.js API?

e.g. "CLI with stylelint 'src/{theme,style,components}/**/*.{js,jsx}'"

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

No

What did you expect to happen?

No warnings to be flagged.

What actually happened (e.g. what warnings or errors did you get)?

The following warnings were flagged:

Checking formatting...
TypeError: family.forEach is not a function
    at /XXX/src/components/Chevron/styles.js:7:3
    at /XXX/node_modules/@signal-noise/stylelint-scales/lib/rules/font-family/index.js:35:14
@digitaljohn digitaljohn added the bug Something isn't working label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants