Python bindings #56
Open
Python bindings #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Open
| > **CT-ICP** comes with python bindings. To build the python bindings, follow the following instructions: | ||
|
|
||
| - 1. Install the superbuild (**with pybind11** /!\ ) | ||
| - 2. Install `CT_ICP` (see Step 1., with the CMake option `WITH_PYTHON_BINDING` activated) |
There was a problem hiding this comment.
You can install it with the 2nd step instead of the 1st. For me on Ubuntu 20.04 superbuild fails after a successful build of a Eigen3_ext target. But the 2nd option worked alright, and generated a shared library.
There was a problem hiding this comment.
Okay, maybe it actually doesn't work that easily, huh. I get undefined references for the shared slam core lib...
gyscos
reviewed
Sep 27, 2023
| dataset_option = Arguments.DATASET_OPTION.dataset | ||
| elif parsed_args.ply: | ||
| dataset_option = Arguments.DATASET_OPTION.ply | ||
| elif parsed_args.config: |
There was a problem hiding this comment.
There is no config option in the arguments.
Did you mean dataset_config? From up there.
Suggested change
| elif parsed_args.config: | |
| elif parsed_args.dataset_config: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Python Bindings, in order to be able to run ct_icp within pylidar-SLAM
TODOS:
SlamCore
CT-ICP
TESTS, CI, Doc