Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow border colors to be set in style #257

Closed
ripienaar opened this issue Feb 24, 2023 · 5 comments · Fixed by #259
Closed

Allow border colors to be set in style #257

ripienaar opened this issue Feb 24, 2023 · 5 comments · Fixed by #259
Assignees
Labels
enhancement New feature or request

Comments

@ripienaar
Copy link

Is your feature request related to a problem? Please describe.

Style customization is great, but I would like a more subtle change from eg rounded to red than the full visual change that is possible now.

Describe the solution you'd like

It would be great leave the overall style as is (eg rounded) but change just the border colors.

Describe alternatives you've considered

I like the customization options, but the switch between them can be quite drastic. So considering the existing ones I want to offer some more in addition.

@jedib0t jedib0t self-assigned this Feb 24, 2023
@jedib0t jedib0t added the enhancement New feature or request label Feb 27, 2023
@jedib0t
Copy link
Owner

jedib0t commented Feb 27, 2023

Hey @ripienaar ... supported it in tag v6.4.5.

Usage example: https://github.com/jedib0t/go-pretty/blob/v6.4.5/table/render_test.go#L961-L962

@ripienaar
Copy link
Author

Amazing thank you

@ripienaar
Copy link
Author

I am struggling a bit with this, but your tests seem to do the right thing so not sure what is wrong here. Hopefully you can help me spot my bug?

Screenshot 2023-02-27 at 21 53 00

I print the style there with a %+v and then the table, seems the top and header colors are wrong while rest fine, and not yet been able to get it consistent, any hins?

@jedib0t
Copy link
Owner

jedib0t commented Feb 27, 2023

@ripienaar Sorry I missed coloring the borders around the "title" of the table. I've fixed it in #260 and cut a new tag for you: https://github.com/jedib0t/go-pretty/releases/tag/v6.4.6

@ripienaar
Copy link
Author

ripienaar commented Feb 28, 2023

perfect now, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants