Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when passing wrong public key #12

Closed
rugk opened this issue Dec 29, 2015 · 3 comments
Closed

Better error message when passing wrong public key #12

rugk opened this issue Dec 29, 2015 · 3 comments

Comments

@rugk
Copy link
Contributor

rugk commented Dec 29, 2015

When you pas the wrong public key (and e.g. accidentally use the signature) you get a base64 error.

# minisign -Vm minisign -P fsadf
base64 conversion failed

I think this error message could be improved as the user does not know what failed to be converted and generally you do not really know what you did wrong here.

@jedisct1
Copy link
Owner

a205a35 should improve this. Thanks!

@rugk
Copy link
Contributor Author

rugk commented Dec 29, 2015

Nice, but what about "valid" or "correct" rather than "actual"? Just an idea - I think this is more precise.

@jedisct1
Copy link
Owner

Because a signature that looks like a signature is not necessarily correct nor valid for the given message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants