Added the serde_support feature #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, So because of the size of the arrays inside SecretKey and Signature, it is at the moment not possible to just use the derive macro. This was an unexpected deep dive into serde and I must say it is not nice to see how the sausage is made. Let me know what you think. |
|
I discovered |
This change adds the serde_support feature, which when enabled adds Serialize and Deserialize implementations for * KeyPair, * SecretKey, * PublicKey, and * Signature The Serialization is done manual, because of the of the large size of the bytes array in SecretKey (64) and Signature (64) and for consistency also for PublicKey. All these Types are serialized to a NeytypeStruct holding a bytes array. While the NewtypeStruct should be ignored by the Serializer implementations > Serializers are encouraged to treat newtype structs as insignificant wrappers > around the data they contain. A reasonable implementation would be to forward > to value.serialize(self). But not all do. Moved all serde related parts into a separate module.
|
Should this PR be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the serde_support feature, which when enabled adds
Serialize and Deserialize implementations for
The Serialization is done manual, because of the of the large Size of the bytes array in SecretKey
(64) and Signature (64) and for consistency also for PublicKey.
All these Types are serialized to a NeytypeStruct holding a bytes array.
While the NewtypeStruct should be ignored by the Serializer implementations
But not all do.
Only KeyPair uses the derive macro.