Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release Tag #245

Open
code28 opened this issue Mar 12, 2021 · 8 comments
Open

New Release Tag #245

code28 opened this issue Mar 12, 2021 · 8 comments

Comments

@code28
Copy link
Contributor

code28 commented Mar 12, 2021

I need the commit 8f94369 in my code, but unfortunately in different libraries, so that SPM doesn't work using another reference than tags. So it'd be great, if you could add a new release tag for master's head.
Thank you! 馃檹

@johnalanwoods
Copy link
Contributor

SPM let's you use master or a commit:

Screenshot 2021-05-24 at 21 31 38

@code28
Copy link
Contributor Author

code28 commented May 25, 2021

@johnalanwoods I know, but it fails, if your dependency uses this repo as well. (Even if both point to the same commit or branch.)

@infa-jowoods
Copy link

Oh wow. Ok. Which other lib are you using out of interest ?

@code28
Copy link
Contributor Author

code28 commented May 25, 2021

It's a private lib I use in different projects. (But I was able to remove the dependency on swift-sodium, so now it's possible to just use a revision in the main project. Nevertheless I think, a new release tag is necessary for swift-sodium.)

@samdowd
Copy link

samdowd commented Sep 9, 2021

+1 on this

We need the change from ea3116e to support iOS 9+ in a pod we're distributing that depends on sodium. Podspecs don't allow us to point to anything other than a specific version number, so we need a version bump (preferably pushed to the pod trunk if possible) to get at that commit. And 0.8.0 won't pass a pod lint because of the Xcode 12 arm64 changes.

Or if anyone has better ideas, happy to hear them. But it does seem like this is a good solution since there's been a libsodium update and some good improvements since the last version bump.

Thanks!

@alexmorrisnz
Copy link

Hi @jedisct1 Can you please create a new release tag (and if possible release on CocoaPods CDN) to resolve this?

@Semty
Copy link

Semty commented Sep 29, 2023

@jedisct1 any updates?

@jedisct1
Copy link
Owner

@Semty Any help on getting HKDF and AEGIS bindings that were introduced in libsodium 1.0.19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants