Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Skip binary files #45

Closed
fregante opened this issue Dec 5, 2016 · 7 comments
Closed

Skip binary files #45

fregante opened this issue Dec 5, 2016 · 7 comments

Comments

@fregante
Copy link

fregante commented Dec 5, 2016

If I were to run

$ eclint check *

eclint runs on all binary files, but these should be ignored, perhaps using is-binary-path as a blacklist or is-text-path as a whitelist

@alexander-akait
Copy link

/cc @jedmao

@jednano
Copy link
Owner

jednano commented Jan 17, 2017

The EditorConfig js core is one of many cores and should be the one responsible for handling this request. I think this issue would be best requested in the general EditorConfig issue tracker so that all cores would ignore binary files, if accepted. Until then, i don't think this is an eclint concern.

@jednano
Copy link
Owner

jednano commented Jan 18, 2017

Reopening in response to editorconfig/editorconfig-core-js#42 (comment). Willing to accept a PR, but I'm not really maintaining this project any more these days.

@gucong3000
Copy link
Collaborator

@bfred-it fixed in master branch.

@fregante
Copy link
Author

fregante commented Mar 6, 2017

Excellent! Thank you 🙂

@fregante fregante closed this as completed Mar 6, 2017
@jednano
Copy link
Owner

jednano commented Mar 6, 2017

I haven't released what's on master yet though. I'm waiting for DefinitelyTyped/DefinitelyTyped#14996.

@jednano
Copy link
Owner

jednano commented Mar 22, 2017

The type def has landed!

@jednano jednano mentioned this issue Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants