New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakpoints apply to all sliders, not just the one specified #205
Comments
This seems similar to something i've been experiencing, in that the last declared rule is applied to all sliders. However, I noticed this whilst using the peek option. In the example below both sliders will have a peek of 30px each side
Glide 3.0.1 here. Sorry to muddy the waters if you feel this is unrelated, I just saw some similarities in our issues. |
Possibly. If you load the page at less than 800px wide, then it works fine until you resize the browser. It could either be because those calculations are made after the resizing and therefore after the rest of the rules, or that they are just applied incorrectly (indiscriminately on all sliders). I did try rearranging the rules so that 'type: carousel' was listed last, but the same happened. The key seems to be how breakpoints are applied on resize. (Or maybe how all inset objects are applied, if yours is the same issue). |
So on first page load when the viewport is below 800px the first slider shows 1 per view, and the second slider 2 per view, but then they both display 2 per view when you resize above 800px and then back to below 800px? Is that correct? |
I've done some research and it looks like recent 3.0.1 fix introduced this problem :( Can someone try downgrade to version 3.0.0 and let me know if I'm right? |
I downgraded to 3.0.0 and that seems to have fixed the issue I was experiencing with the peek option. |
I tested with the OP's code on 3.0.0 and that seems to work as well now in my codepen here |
Should be fixed with |
It's working in my updated codepens |
Ah thanks, the bug is fixed if I use glide.js (v3.0.2) on my dev site. |
Oh, @mattisherwood you are right. Uglify has broke minified version, need to investigate that. |
Also, I'm getting issues in Internet Explorer (v11.371.16299.0) now where the sliders just refuse to work. |
ie's debugger says "SCRIPT438: Object doesn't support property or method 'from'" and points to:
|
@mattisherwood |
@mattisherwood Thanks for detailed bug reports 👍. Addressed this issues with
Minified file for
I've swapped PS. I'm closing this issue for now. If you find any other problems feel free to open new topic :) |
the breakpoint rules are applied to all sliders on the page, not just the one it's a part of.
e.g. glide1 should show 3 on desktop and 1 on mobile whilst glide2 should show 6 on desktop and 2 on mobile. However, on mobile they both show 2.
PS - I'm using Glide 3.0
The text was updated successfully, but these errors were encountered: