-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer dependencies missing with npm 3+ #50
Comments
Note that this issue also applies if npm was updated on a 12.7 nodejs. Doing a simple:
reproduces this issue. |
Have you tried applying my pull request #51 ? |
@JBBr I applied #51 and it works as advertised. I tested it as follows: 1 - ran against the 0.12.7 node / 2.x npm. Hello world works.
4 - cd to in the project directory, then:
It all works! Thanks for your PR! |
Yeah, thanks @JBBr! As I noted in the PR, I'm going to wait to merge such changes until I can make the script support npm 2 or 3 out of the box. |
Thanks for merging, problem should be fixed now |
When using latest node 4.1.0 with npm 3.3 this package does not work anymore as it depends on peerDependencies of babel-core and others.
Most problematic: core-js is not available anymore in node_modules/babel-core/node_modules/core-js
I assume
core-js
has to be added as top level dependency and thecore-js-custom-build
has to be adjusted.The text was updated successfully, but these errors were encountered: