Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies missing with npm 3+ #50

Closed
jthomaschewski opened this issue Sep 18, 2015 · 5 comments
Closed

Peer dependencies missing with npm 3+ #50

jthomaschewski opened this issue Sep 18, 2015 · 5 comments

Comments

@jthomaschewski
Copy link
Contributor

When using latest node 4.1.0 with npm 3.3 this package does not work anymore as it depends on peerDependencies of babel-core and others.

Most problematic: core-js is not available anymore in node_modules/babel-core/node_modules/core-js

I assume core-js has to be added as top level dependency and the core-js-custom-build has to be adjusted.

@ihistand
Copy link

Note that this issue also applies if npm was updated on a 12.7 nodejs. Doing a simple:

sudo npm update -g 

reproduces this issue.

@jthomaschewski
Copy link
Contributor Author

Have you tried applying my pull request #51 ?
With the fix npm 3 + npm 2 should work fine both

@ihistand
Copy link

@JBBr I applied #51 and it works as advertised. I tested it as follows:

1 - ran against the 0.12.7 node / 2.x npm. Hello world works.
2 - uninstalled node, removed all global node_modules.
3 - installed node 4.1 (built from source on the local Ubuntu box), and updated globally:

sudo npm update -g    # updated npm to 3.3.3
sudo npm install -g babel grunt-cli     # installed babel and grunt-cli globally, as per package recommendations

4 - cd to in the project directory, then:

rm -rf node_modules
npm install
./dev

It all works! Thanks for your PR!
--Ivan

@jedwards1211
Copy link
Owner

Yeah, thanks @JBBr! As I noted in the PR, I'm going to wait to merge such changes until I can make the script support npm 2 or 3 out of the box.

@jthomaschewski
Copy link
Contributor Author

Thanks for merging, problem should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants