Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles from input not being copied to hidden div #99

Closed
mvf4z7 opened this issue Aug 28, 2017 · 2 comments
Closed

Styles from input not being copied to hidden div #99

mvf4z7 opened this issue Aug 28, 2017 · 2 comments

Comments

@mvf4z7
Copy link
Contributor

mvf4z7 commented Aug 28, 2017

I noticed that font related styles from the visible input were not being properly copied to the hidden div used for calculating the size. This was causing the size of the input to be incorrect (too large), as the font-size of the div was larger than that of the input.

After changing this line to return when the compoennt is NOT mounted it seemed to fix the issue

e.g. if (!this.mounted || !window.getComputedStyle) {

@slavab89
Copy link

Someone already opened the exact same PR #91 😄 We're still waiting for it to get merged

@JedWatson
Copy link
Owner

Should be fixed as of 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants