Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select element cannot be disabled #46

Closed
julen opened this issue Jan 12, 2015 · 4 comments
Closed

Select element cannot be disabled #46

julen opened this issue Jan 12, 2015 · 4 comments

Comments

@julen
Copy link
Contributor

julen commented Jan 12, 2015

If you pass the disabled prop to the <Select /> element, it's completely ignored.

This should:

  1. Pass the prop to the hidden <input /> element.
  2. Do not render the <Input /> element from react-autosize at all, and only display the placeholder instead.
  3. Adjust the default styling for a disabled <Select /> element.

If you are OK with it, I can provide a PR for this.

@JedWatson
Copy link
Owner

Good call @julen, I'd be really happy for a PR for this. If you want, @jossmac can do the styling for an -is-disabled class.

@dannyshaw
Copy link

submitted a pull request in reference to this.

@julen
Copy link
Contributor Author

julen commented Feb 13, 2015

So unfortunate I have this locally done but didn't find time to create the PR :( (can't assign issues myself)

@JedWatson
Copy link
Owner

Closed by @dannyshaw's PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants