Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta 2.0 has less themes, add feedback here #115

Closed
paulvi opened this issue Mar 7, 2014 · 11 comments
Closed

beta 2.0 has less themes, add feedback here #115

paulvi opened this issue Mar 7, 2014 · 11 comments

Comments

@paulvi
Copy link
Contributor

paulvi commented Mar 7, 2014

I have tried 2.0 (from http://jeeeyul.github.io/beta-update), look great.

However it has less themes, and I think something else is missing.

Are you cooperating with @guari on black theme?

@jeeeyul
Copy link
Owner

jeeeyul commented Mar 7, 2014

I don't coop with any other for now.
I will not release black theme through public release.
(It is test purpose, Basically I don't like tons of side effect that coming with black theme).

Instead, I will provide extension point that allows anyone can easily provide preset.
I'm creating Documents about CSS and Deploy your preset Guide documents to support them.

@jeeeyul
Copy link
Owner

jeeeyul commented Mar 7, 2014

@paulvi by the way, Can you point "missing" elements?

@paulvi
Copy link
Contributor Author

paulvi commented Mar 9, 2014

  • there were 10 themes, now there are 2-3
  • tool for user presets
  • tools were reorganized, and while there was not list of tool, it is hard to say what exactly added or removed....

@musinsky
Copy link

Can you please add preset Adwaita(from previous version) in v 2.0

Thanks

@paulvi
Copy link
Contributor Author

paulvi commented Mar 13, 2014

2.0 is already not Betta. Should we close this issue?

@paulvi
Copy link
Contributor Author

paulvi commented Mar 13, 2014

I will not release black theme through public release.
(It is test purpose, Basically I don't like tons of side effect that coming with black theme).

Yes, that is a bunch of work that @guari has been doing.

Also for #112 can this plugin reference others Eclipse themes? (That is all themes installed).
Maybe @vogella knows if somewhat alike is to come with Eclipse. And it is one more example were efforts can overlap.

@vogella
Copy link

vogella commented Mar 13, 2014

@paulvi we have integrated the theme from @guari into Eclipse Luna M6 and Andrea is helping to improve it further in M7. You can checkout it out via the nightly builds http://download.eclipse.org/eclipse/downloads/ or via the Git repository see
http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#eclipseplatformsource

git clone git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git and plugin is org.eclipse.ui.themes

@paulvi We (Eclipse team) are open of patches to improve the dark theme.

@paulvi
Copy link
Contributor Author

paulvi commented Mar 13, 2014

@vogella Thank you, I already know and let @jeeeyul know too guari/eclipse-ui-theme#49

@jeeeyul @guari @Nodeclipse all are open for improvement. It is more about desire and easiness to start.

http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#eclipseplatformsource
link is great, should be in #99 as an intro and explanation.

@vogella
Copy link

vogella commented Mar 13, 2014

@paulvi @jeeeyul @Nodeclipse as of Luna we also have the option to import existing CSS files and extend them. So he you want you could extend the platform dark theme from @guari and extend it.

See http://blog.vogella.com/2014/03/11/import-css-files-in-eclipse-luna-m6/

@paulvi Thanks that you like http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html, I add a section about CSS contribution to it, so that it will be easier for people to contribute.

@vogella
Copy link

vogella commented Mar 13, 2014

OK add a section about CSS to my tutorial http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#areasforcontributions_css

I also heavily update http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html I hope this help with potential contributions.

@jeeeyul
Copy link
Owner

jeeeyul commented Mar 14, 2014

@musinsky get updated with 2.1.0 and see What I'v done! :)
I hope that you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants