Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle_pause doesn't work with a specific sequence #307

Closed
marcusx2 opened this issue Jul 15, 2023 · 1 comment
Closed

toggle_pause doesn't work with a specific sequence #307

marcusx2 opened this issue Jul 15, 2023 · 1 comment

Comments

@marcusx2
Copy link

I am trying out toggle_pause, and there seems to be a specific case where it doesn't work as expected.

Here's a table of tests of pause/unpause. For example true true/false true means I called toggle_pause(true, true) to pause, then toggle_pause(false, true) to unpause

true true/false true -> works
true true/false false -> doesn't work.
true false/false true -> works
true false/ false false -> works

I don't know if this is working as intended, but it seems wrong. I think the second parameter should be ignored if I am unpausing and the video stream should come back, right? But if I call true true/false false, the screen stays frozen, the video stream seemingly doesn't come back.

@xavierjs
Copy link
Member

xavierjs commented Jul 16, 2023

Hi

If you call toggle_pause and you shut down the video stream (true, true), then when resuming you need to turn on the video stream, so you need to call the function with false, true as arguments. Calling the function with true, true then false, false is nonsense. The second parameter should have the same value for both calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants