Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(amazon): adds most available AIB cards #1140

Merged
merged 4 commits into from
Dec 4, 2020
Merged

chore(amazon): adds most available AIB cards #1140

merged 4 commits into from
Dec 4, 2020

Conversation

jaw20
Copy link
Contributor

@jaw20 jaw20 commented Dec 3, 2020

Description

This pull request addresses and fully resolves #1098 and resolves #1160. This also adds the missing required AIB model to store.ts. This also addresses an issue in bestbuy.ts where an rx6800 card was reporting as an rx6800xt.

This fully addresses jef#1098 with the AIB cards for Big Navi that are on amazon getting added in. (At least the ones I could find.)
@jaw20 jaw20 requested a review from jef as a code owner December 3, 2020 18:26
@jaw20
Copy link
Contributor Author

jaw20 commented Dec 4, 2020

Bumping for visibility

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the additions.

@jef jef changed the title chore(amazon): adds most available AIB cards to amazon.ts chore(amazon): adds most available AIB cards Dec 4, 2020
@jef jef merged commit 3b4fe78 into jef:main Dec 4, 2020
@jaw20 jaw20 deleted the patch-1 branch December 4, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An RX 6800 in Bestbuy.ts is improperly identified as an RX 6800xt Add AIBs for Big Navi
2 participants