Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add xfx brand #1182

Merged
merged 3 commits into from
Dec 6, 2020
Merged

docs: add xfx brand #1182

merged 3 commits into from
Dec 6, 2020

Conversation

rdfurman
Copy link
Contributor

@rdfurman rdfurman commented Dec 5, 2020

Description

XFX was missing from readme so I added it.

Testing

Screenshot:
image

New dependencies

None.

@rdfurman rdfurman requested a review from jef as a code owner December 5, 2020 00:36
@rdfurman rdfurman mentioned this pull request Dec 5, 2020
Closed
@rdfurman
Copy link
Contributor Author

rdfurman commented Dec 5, 2020

Woops, made it alphabetical:
image

@jaw20
Copy link
Contributor

jaw20 commented Dec 5, 2020

You should also add sapphire and their related models.

jef
jef approved these changes Dec 6, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@jef jef changed the title chore: Add xfx brand to readme docs: add xfx brand Dec 6, 2020
@jef jef merged commit 0c59d1e into jef:main Dec 6, 2020
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdfurman @jaw20 @jef