Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): update UK stores #1372

Merged
merged 4 commits into from
Dec 13, 2020
Merged

fix(store): update UK stores #1372

merged 4 commits into from
Dec 13, 2020

Conversation

YiIdirim
Copy link
Contributor

@YiIdirim YiIdirim commented Dec 12, 2020 •
edited

Description

Fixes #1348

New features:

  • AMD-UK: New store that scans for all Ryzen 5000 and RX 6000 series products.

Bug fixes and improvements:

  • Amazon-UK: Add RTX 3070.
  • Argos: Updated PS5 links. Add Xbox Series S/X.
  • Aria: Add RTX 3070. Remove duplicate 3060ti link builder.
  • AWD-IT: Updated container labels to more accurately parse info. Remove hard-coded links in favour of link builders. Add RX 6800/XT series. Remove duplicate RTX 3060Ti link builder.
  • Box: Add backoffstatuscodes. Update price and outOfStock container labels. Add PS5 and Xbox Series S/X models. Add RX6900XT model.
  • CCL: Add RX 6900XT.
  • Currys: Remove duplicate RTX 3060ti link builder. Add PS5 and Xbox Series S/X consoles.
  • eBuyer: Update labels. Add Xbox Series S/X consoles. Add RX 6900XT.
  • Game: Add Xbox Series S/X consoles.
  • Overclockers: Add RX 6900XT. Remove duplicate RTX 3060ti link builder.
  • Scan: Update test link to a product that is in stock. Remove hard-coded links in favour of link builders for RX 6800/XT and RX 6900XT. Removed duplicate 3060ti link builder. Fixed a particular RTX 3070 card not correctly being parsed.

Testing

Manual testing has been performed to verify the changes are robust.

@YiIdirim YiIdirim requested a review from jef as a code owner December 12, 2020 16:44
@YiIdirim YiIdirim changed the title fix(store): updated uk stores fix(store): update uk stores Dec 12, 2020
@YiIdirim YiIdirim changed the title fix(store): update uk stores fix(store): update UK stores Dec 12, 2020
jef
jef approved these changes Dec 13, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Amazing! Thank you so much @Sohaiiil. I really appreciate the work you put in here!

@jef jef merged commit 02825d0 into jef:main Dec 13, 2020
@YiIdirim YiIdirim deleted the uk-store-updates branch December 13, 2020 12:34
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YiIdirim @jef