Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lookup): check out of stock before price #1422

Merged
merged 1 commit into from
Dec 15, 2020
Merged

fix(lookup): check out of stock before price #1422

merged 1 commit into from
Dec 15, 2020

Conversation

carrierfry
Copy link
Contributor

Checking for Out of Stock before checking for max Price

Description

Fixes #1421

Testing

Tested it briefly on Ubuntu Desktop 20.04 and it worked

New dependencies

none

Checking for Out of Stock before checking for max Price
@carrierfry carrierfry requested a review from jef as a code owner December 15, 2020 13:33
@carrierfry carrierfry changed the title Update lookup.ts Fix: Update lookup.ts Dec 15, 2020
@carrierfry carrierfry changed the title Fix: Update lookup.ts fix: Update lookup.ts Dec 15, 2020
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, mhm. This makes sense to me!

Thanks for the contribution 😁

@jef jef changed the title fix: Update lookup.ts fix(lookup): check out of stock before price Dec 15, 2020
@jef jef merged commit 02d29c3 into jef:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some out of stock items are checked for max price before out of stock check
2 participants