Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): link builder in UK stores #1486

Merged
merged 5 commits into from
Dec 21, 2020
Merged

fix(store): link builder in UK stores #1486

merged 5 commits into from
Dec 21, 2020

Conversation

YiIdirim
Copy link
Contributor

Description

Fixes #1485

  • Amazon-UK: RTX cards were not being parsed correctly. Use hard-coded links for better reliability
  • eBuyer: PS5 consoles links updated

Testing

  • Scan for RTX cards at Amazon
  • Scan for consoles at eBuyer
  • They should usually show OUT OF STOCK and show IN STOCK when available

@YiIdirim YiIdirim requested a review from jef as a code owner December 21, 2020 12:43
jef
jef approved these changes Dec 21, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! The link builder is great in theory, but can be very finicky. Thanks for adding these in!

@jef jef enabled auto-merge (squash) December 21, 2020 17:38
@jef jef disabled auto-merge December 21, 2020 18:01
@jef jef changed the title fix(store): couple of UK stores fix(store): link builder in UK stores Dec 21, 2020
@jef jef merged commit eb59dc3 into jef:main Dec 21, 2020
@jef
Copy link
Owner

jef commented Dec 21, 2020

Thank you @Sohaiiil!

@YiIdirim YiIdirim deleted the uk-update branch December 21, 2020 21:17
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some UK store links need updating
2 participants
@YiIdirim @jef