Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add GPU and CPU support for Vuugo #1555

Merged
merged 3 commits into from
Jan 3, 2021
Merged

feat(store): add GPU and CPU support for Vuugo #1555

merged 3 commits into from
Jan 3, 2021

Conversation

anthonytam
Copy link
Contributor

Description

Added an additional Canadian store Vuugo with support for all available RTX 3000 series, RX 6000 series and Ryzen 5000 series components.

Also added two additional GPU Models which were available at Vuugo but not previously added

Testing

Edited the env confirmation to add the new store:

...  
STORES=vuugo  
...

Ran the application to verify stock was checked including the test item

[2:51:22 p.m.] info :: 🚀🚨 [vuugo] [test:brand (test:series)] test:model :: IN STOCK 🚨🚀  
https://www.vuugo.com/computer-hardware/computer-parts/hard-drives/seagate-hard-drive-ST1000LM048.html  
[2:51:25 p.m.] info :: ✖ [vuugo] [asrock (rx6900xt)] amd reference :: OUT OF STOCK  
[2:51:27 p.m.] info :: ✖ [vuugo] [asus (3060ti)] dual oc :: OUT OF STOCK  
[2:51:30 p.m.] info :: ✖ [vuugo] [asus (3070)] dual :: OUT OF STOCK  
[2:51:33 p.m.] info :: ✖ [vuugo] [asus (3070)] dual oc :: OUT OF STOCK  
[2:51:35 p.m.] info :: ✖ [vuugo] [asus (3060ti)] strix oc :: OUT OF STOCK  
[2:51:38 p.m.] info :: ✖ [vuugo] [asus (3070)] ko :: OUT OF STOCK

I've also fixed all lint errors which were identified

@anthonytam anthonytam requested a review from jef as a code owner December 29, 2020 21:50
jef
jef approved these changes Jan 3, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! There's a lot of product here. Thanks for the contribution!

@jef jef changed the title feat(store): Added GPU and CPU support for Vuugo feat(store): add GPU and CPU support for Vuugo Jan 3, 2021
@jef jef merged commit 8ab6e1f into jef:main Jan 3, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@anthonytam @erwinc1
feat(store): add GPU and CPU support for Vuugo (jef#1555)
7069db8
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonytam @jef