Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wipoid): added 3090/3080/3070/3060ti/ryzen store items #1683

Merged
merged 5 commits into from
Jan 14, 2021
Merged

fix(wipoid): added 3090/3080/3070/3060ti/ryzen store items #1683

merged 5 commits into from
Jan 14, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 14, 2021

Description

Partly Fixes #1676 for wipoid stock not to be up to date at all.

Updated Store contents for wipoid:

  • Ryzen 5950 / 5900 added
  • Added all currently listed 3090 cards not in config
  • Added all currently listed 3080 cards not in config
  • Added all currently listed 3070 cards not in config ( there were none in the config )
  • Added all currently listed 3060ti cards not in config ( there were none in the config )
  • update store.ts for additional card types currently missing
  • Updated filter.md to fit missing card combinations to documentation

Testing

-> Ryzen was tested successfully
image

-> 3090 was tested successfully
image

-> 3080 was tested successfully
image

-> 3070 was tested successfully
image

-> 3060ti was tested successfully
image

@wofnull
Wipoid:
cf8f2d9 
- added AMD Ryzen 5950x
- added AMD Ryzen 5900x
@wofnull
Wipoid:
a543184 
- Added all currently listed 3090 models
- Updated filter.md for documentation
- Updated store.ts for missing models
@wofnull
Wipoid:
c9f0013 
- Added additional 3080 cards missing in current config
@wofnull
Wipoid:
b2f0695 
- Added all available 3070 Models ( none were listed before in config )
- updated filter.md with missing pny xlr8 epic x model for documentation
@wofnull
Wipoid:
0a81495 
- Added all available 3060ti Models ( none were listed before in config )
- updated filter.md with missing card combination gigabyte -> gaming oc pro
@wofnull wofnull requested a review from jef as a code owner January 14, 2021 09:26
@wofnull
Copy link
Contributor Author

wofnull commented Jan 14, 2021

Unluckily this will not solve the maxPrice issue from the open issue.
As i found that the site puts an space in the price if the price is over 1000 € like in https://www.wipoid.com/gigabyte-aorus-z390-xtreme-waterforce.html where the price is not displayed as 1069 € but 1 069 € the script assumes that the price is about 1 €.

I do not know if the script is able to correct this on its own, but luckily in the source of the site the price is noted as followed:
image
therefore the correct price is in the source of the site under content, but again, i do not know if the script is currently capable to catch this number instead of the public displayed one.

But as said before, this one patch was only to update the cards for the site.

jef
jef approved these changes Jan 14, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much! 🚀

@jef jef merged commit be54171 into jef:main Jan 14, 2021
@wofnull wofnull deleted the wipoid_patch branch January 14, 2021 14:17
tylermilner added a commit to tylermilner/streetmerchant that referenced this pull request Jan 15, 2021
@tylermilner
Merge branch 'main' of github.com:jef/streetmerchant into feature/add…
c66f6b6 
…-microcenter-out-of-stock

* 'main' of github.com:jef/streetmerchant: (23 commits)
  chore(deps-dev): bump webpack from 5.13.0 to 5.14.0 (jef#1692)
  chore(deps): bump puppeteer-extra from 3.1.15 to 3.1.16 (jef#1678)
  chore(deps): bump puppeteer-extra-plugin-block-resources from 2.2.7 to 2.2.8 (jef#1691)
  chore(deps): bump google-github-actions/release-please-action from v2.14 to v2.15 (jef#1655)
  chore(deps): bump @slack/web-api from 5.15.0 to 6.0.0 (jef#1669)
  fix(bandh): asus cards / out of stock check added (jef#1670)
  chore(deps): bump puppeteer-extra-plugin-stealth from 2.6.5 to 2.6.6 (jef#1680)
  chore(deps): bump twilio from 3.54.2 to 3.55.0 (jef#1679)
  chore(deps): bump puppeteer-extra-plugin-adblocker from 2.11.9 to 2.11.10 (jef#1681)
  chore(computeruniverse): add 3060ti cards (jef#1665)
  fix(wipoid): added 3090/3080/3070/3060ti/ryzen store items (jef#1683)
  feat(vsgamers): add maxPrice selector(jef#1682)
  fix(galaxus): update selector  ( 14.01.2020 07:00 ) (jef#1664)
  docs: add hyperlinks
  docs(twitch): add instructions on how to get tokens
  chore(lint): add void for dangling promise
  chore(deps): bump dependencies
  feat(twilio): add support to have multiple numbers (jef#1450)
  feat(galaxus): update selector, add out of stock check (jef#1607)
  feat(asus): add outOfStock label (jef#1653)
  ...
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@wofnull @erwinc1
fix(wipoid): added 3090/3080/3070/3060ti/ryzen store items (jef#1683)
96e16e2
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Price filter not working (maybe caused for numerical representation of the price)
2 participants
@wofnull @jef