Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Amazon-uk is ignoring MAX_PRICE_SERIES filter #2813

Closed
1 task done
LilPeck1 opened this issue Oct 20, 2021 · 5 comments · Fixed by #2856
Closed
1 task done

[Bug]: Amazon-uk is ignoring MAX_PRICE_SERIES filter #2813

LilPeck1 opened this issue Oct 20, 2021 · 5 comments · Fixed by #2856

Comments

@LilPeck1
Copy link

Expected Behavior

Streetmerchant should have ignored the amazon-uk items that were coming back with higher price tags than what was specified in the MAX_PRICE_SERIES filter.

Current Behavior

Streetmerchant is instead accepting amazon-uk items that have a higher price tag than what is specified in the MAX_PRICE_SERIES filter.

What operating system are you seeing the problem on?

Windows

Relevant log output

n/a

Configuration

# ** All configuration variables are optional **
# Copy this file and name it as `dotenv` (without backticks)
# Read https://jef.buzz/streetmerchant/getting-started/#customization for help on customizing this file
########################################################################################################
EMAIL_PASSWORD=Password
EMAIL_USERNAME=Email
LOW_BANDWIDTH=true
MAX_PRICE_SERIES_3070=500
MAX_PRICE_SERIES_3070TI=600
MAX_PRICE_SERIES_3080=700
SHOW_ONLY_SERIES=3070,3080,3070ti
STORES=amazon-uk,amd-uk,ao,argos,aria,awd,box,bt,ccl,corsair-uk,currys,ebuyer,game,johnlewis,novatech,overclockers,scan,shopto,smythstoys,very,nvidia-gb
SMTP_ADDRESS=smtp-mail.outlook.com
SMTP_PORT=587

Code of Conduct

  • I agree to follow this project's Code of Conduct
@LilPeck1
Copy link
Author

I'm not a coder so bear with me... I looked through the src\store\model\amazon-uk file and saw that it was referencing the US priceblock_ourprice container. I don't think the UK uses the same one, although I'm not sure what its alternative is. I tried a few things in its place but it didn't seem to work. For all I know this could be completely irrelevant?

@mayors1
Copy link

mayors1 commented Oct 28, 2021

Amazon-DE is equally impacted. According to other issues, we arent alone on this one. This "bug" persists since July tho apparently with no fixes. Best idea would be to just remove amazon-Uk from your list

@Froghut
Copy link

Froghut commented Nov 18, 2021

For amazon.de at least it seems the fix is to open src\store\model\amazon-de.ts and change '#priceblock_ourprice' to '.a-text-price'.

@MurrayGroves
Copy link
Contributor

For amazon.de at least it seems the fix is to open src\store\model\amazon-de.ts and change '#priceblock_ourprice' to '.a-text-price'.

This fixed it for me on amazon-uk.

@cyandura
Copy link

cyandura commented Dec 6, 2021

For amazon.de at least it seems the fix is to open src\store\model\amazon-de.ts and change '#priceblock_ourprice' to '.a-text-price'.

Can confirm this problem is happening for amazon US and this fix works. labels.maxPrice.container just needs to be updated

@jef jef closed this as completed in #2856 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants