Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type handler uberjars contain redundant classes #23

Open
jeff303 opened this issue Mar 23, 2024 · 0 comments
Open

Type handler uberjars contain redundant classes #23

jeff303 opened this issue Mar 23, 2024 · 0 comments

Comments

@jeff303
Copy link
Owner

jeff303 commented Mar 23, 2024

jar tvf type-handlers/avro/target/kc-repl-type-handler-avro-1.1.26-avro-handler.jar | grep KafkaConsumer
 51983 Thu Jul 14 04:52:06 CDT 2022 org/apache/kafka/clients/consumer/KafkaConsumer.class
  4820 Thu Jul 14 04:52:06 CDT 2022 org/apache/kafka/clients/consumer/internals/KafkaConsumerMetrics.class
jar tvf target/kc-repl-1.1.26-standalone.jar | grep KafkaConsumer
 51950 Thu Sep 29 12:21:34 CDT 2022 org/apache/kafka/clients/consumer/KafkaConsumer.class
  4820 Thu Sep 29 12:21:34 CDT 2022 org/apache/kafka/clients/consumer/internals/KafkaConsumerMetrics.class

This is an example of a class that only needs to be in the latter uberjar. The specific type handler jars could be smaller if they don't package these classes. It seems like we basically need the equivalent of Maven's provided scope for these. Need to look into how to do that in deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant