Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing design #20

Closed
jeffalo opened this issue May 13, 2020 · 3 comments
Closed

confusing design #20

jeffalo opened this issue May 13, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeffalo
Copy link
Owner

jeffalo commented May 13, 2020

right now, we have a download button with the icon of a save button, this gets people thinking that there is no autosave.

i have two solutions to fix this,

#1 replace save icon with download

#2 (the better one) remove the save button from the actions and add a custom context menu for when someone right clicks on a file. this would have another way to acess the rename and delete buttons and also have a download button.

^ i'm not sure how to make a custom context menu, but im sure i can find it on google

@jeffalo jeffalo added the enhancement New feature or request label May 13, 2020
@jeffalo jeffalo self-assigned this May 13, 2020
@mxmou
Copy link
Contributor

mxmou commented May 13, 2020

^ i'm not sure how to make a custom context menu, but im sure i can find it on google

You can listen for "contextmenu" events and call event.preventDefault(). Then show an element with position: fixed at mouse position.

@jeffalo
Copy link
Owner Author

jeffalo commented May 13, 2020

aha thanks :)

@jeffalo
Copy link
Owner Author

jeffalo commented May 15, 2020

done in newest commit

@jeffalo jeffalo closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants