Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

❗ the future of this extension #25

Open
jeffalo opened this issue Aug 23, 2020 · 18 comments
Open

❗ the future of this extension #25

jeffalo opened this issue Aug 23, 2020 · 18 comments

Comments

@jeffalo
Copy link
Owner

jeffalo commented Aug 23, 2020

this was a very cool extension to make and share, but i think it would be better for development and user experience for this to be part of a larger extension.

the advantages of using that:

  • all of your scratch related addons are in one place
  • addons don't need to reinvent the wheel for getting scratch related stuff like tokens
    • a cool addon api (cleaner code)
  • a much larger user base (eventually)
  • i don't need to update so many different versions of the script when updates are done, it would be nice in one place

disadvantages

  • updates probably would need to be approved by them
  • releases are on their schedule
  • the code will probably have to be cleaner

the options

  • continue to support the userscript, extension and now the addon in ScratchAddons
  • only update the userscript and extension for big updates (i think this will be the best idea)
  • completely depreciate the userscript and extension and focus efforts on writing for ScratchAddons (i like this one too)

i think this should be discussed since it's pretty important

@NoobTracker
Copy link

I think that that's a pretty good idea ... although that large extension, whatever the features there are, has only 15 stars and this one 11 so I dunno ... still, looks like that has more users. I think that it would make sense.

@jeffalo
Copy link
Owner Author

jeffalo commented Aug 23, 2020

@NoobTracker from what i've heard they plan on rebranding a huge scratch related extension (1k+ users) to ScratchAddons and making it into basically the place to get smaller scratch addons

@NoobTracker
Copy link

That sounds awesome! Dozens of small extensions that make Scratch a little bit cooler but all together a lot cooler! And improving the code is never bad.

@jeffalo
Copy link
Owner Author

jeffalo commented Aug 23, 2020

@NoobTracker yep! that's why i think that project is super cool. (plus the people working on it are very smart)

@NoobTracker
Copy link

But I'm not sure ... it could get a bit messy. Would every extension stay its own repository? If not, then it could get really messy when you try to discuss 50 things in one place.

@NoobTracker
Copy link

But if every extension stays its own thingy and every PR would just also be added to the big thing, then it could work, I think.

@jeffalo
Copy link
Owner Author

jeffalo commented Aug 23, 2020

@NoobTracker yeah, i guess we'll have to wait and see how that goes.

@NoobTracker
Copy link

So what are the features of the extensions in the big extension so far?

@NoobTracker
Copy link

There could also be a script that adds a function for thumbnail and assets uploads so you can create code that does that easier and it would also be less messy.

@NoobTracker
Copy link

Overall it sounds pretty good. And I guess PRs still work.

@NoobTracker
Copy link

@JeffaloBob btw, it may be a good idea to split content.js into content.js and thumbnails.js so you have the code that creates the UI stuff in one file and the one that uploads the images in the other one. Would be less messy.

@BoomerScratch
Copy link
Contributor

Use prettier for formatting code and making it clean. You can also use a GitHub action to automatically format code.

@NoobTracker
Copy link

yeah maybe add some nice semicolons.

@NoobTracker
Copy link

But currently it's not that bad I would say. You haven't seen my code yet.

@NoobTracker
Copy link

@BoomerScratch I can't tell you why, but somehow the code prettier creates is uglier then the original code imo.

@jeffalo
Copy link
Owner Author

jeffalo commented Sep 26, 2020

Scratch Addons has released, and this is now available over there too!

@NoobTracker
Copy link

NoobTracker commented Sep 26, 2020

Yay!
(but wasn't it already available before that release?)

@jeffalo
Copy link
Owner Author

jeffalo commented Sep 26, 2020

Yay!
(but wasn't it already available before that release?)

it was, but telling people to install an unfinished extension through their browser's developer options doesn't really sound that good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants