Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catmaid_login should prefer environment variables #80

Closed
jefferis opened this issue Jun 8, 2017 · 0 comments
Closed

catmaid_login should prefer environment variables #80

jefferis opened this issue Jun 8, 2017 · 0 comments

Comments

@jefferis
Copy link
Collaborator

jefferis commented Jun 8, 2017

Environment variables are the preferred way of storing authentication information. They are inherited by child R processes when set in a parent and are not displayed to the screen when you look at options.

The change that needs to happen here is that catmaid_login should

  1. see if it has been given explicit parameters and if so use those
  2. check for a cached login
  3. check for environment variables
  4. check R options

Right now 1,2 happen in catmaid_login while 4 happens inside catmaid_connection. I guess 3 could also happen inside catmaid_connection.

The package docs/READMEs need to be updated to recommend environment variables. This should have the knock on effect of allowing pkgdown to run vignettes requiring authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant