Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch between tab groups #11

Closed
sojusnik opened this issue Nov 3, 2018 · 8 comments
Closed

Switch between tab groups #11

sojusnik opened this issue Nov 3, 2018 · 8 comments

Comments

@sojusnik
Copy link

sojusnik commented Nov 3, 2018

Instead of tabs, I recently started using tab groups (ctrl+alt+n). Since you can break your fingers with the default shortcuts shift+ctrl+alt+pageup/pagedown (I have to additionally hold fn on my notebook to activate pageup/pagedown) for switching tab groups, I want to modify your plugin to switch tab groups with ctrl+tab. I'm not a programmer, but could figure things out if you could tell me what to replace in your code in order to achieve that behavior.

Thanks in advance!

@jefferyto
Copy link
Owner

Thanks for asking - I think this is the first time I've heard of someone using tab groups 😆

Instead of hacking up this plugin, I wrote another one to do this: Tab Group Salute.

It uses Ctrl+` (backquote / backtick) though; I thought that combination would make more sense. It shouldn't be too hard to change the shortcut keys inside the code if you want, though it won't be possible to bind to Ctrl+Tab directly (it's one of the shortcuts reserved by GNOME).

@sojusnik
Copy link
Author

sojusnik commented Nov 7, 2018

Many thanks! Your solution with ' makes more sense too! The new plugin works well, but I can't cycle back with shift. Do you observe this too?

The problem lies in my keyboard layout! When the German layout is active, shift doesn't work, but if I switch to English or another one, like Russian, then shift works fine.

Do you think that there is a workaround for the German layout?

@jefferyto
Copy link
Owner

You mean Ctrl+Shift+` isn't working for you?

@sojusnik
Copy link
Author

sojusnik commented Nov 7, 2018

You mean Ctrl+Shift+` isn't working for you?

Yes, but only when using a German layout. See my addition above.

@jefferyto
Copy link
Owner

Technically the shortcut key is Ctrl+~; in the US layout backtick and tilde are on the same key but I believe tilde is on a different key in German layouts. I'll have to think about how to detect the current keyboard and adjust the shortcuts dynamically.

@jefferyto
Copy link
Owner

Just pushed a new version, it should work regardless of keyboard layout.

@sojusnik
Copy link
Author

Works great now, thanks!

@jefferyto
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants