Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really fix strict notice in signature/common.php #10

Closed
adrianheine opened this issue Jan 19, 2011 · 1 comment
Closed

Really fix strict notice in signature/common.php #10

adrianheine opened this issue Jan 19, 2011 · 1 comment

Comments

@adrianheine
Copy link

d37339b didn’t fix a fuck – it’s about the param, not the return value. Do this one instead:

--- a/extlib/HTTP/OAuth/Signature/Common.php
+++ b/extlib/HTTP/OAuth/Signature/Common.php
@@ -54,10 +54,9 @@ abstract class HTTP_OAuth_Signature_Common extends HTTP_OAuth
         if (array_key_exists('oauth_signature', $params)) {
             unset($params['oauth_signature']);
         }
-        
-        $croppedUrl = reset(explode('?', $url));
-        
-        $parts = array($method, $croppedUrl,
+
+        $splittedUrl = explode('?', $url);
+        $parts = array($method, $splittedUrl[0],
             HTTP_OAuth::buildHTTPQuery($params));
         $base  = implode('&', HTTP_OAuth::urlencode($parts));
         $this->debug('Signing with base string: ' . $base);
@shupp
Copy link
Collaborator

shupp commented Jul 4, 2011

Fixed in master.

@shupp shupp closed this as completed Jul 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants