Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Functionality Cleanup #52

Closed
jefflester opened this issue Apr 21, 2023 · 1 comment
Closed

Miscellaneous Functionality Cleanup #52

jefflester opened this issue Apr 21, 2023 · 1 comment
Assignees
Milestone

Comments

@jefflester
Copy link
Owner

jefflester commented Apr 21, 2023

A few things could be touched up in Minitrino:

  1. Instead of using bootstrap scripts for config.properties management, we could use a more user-friendly approach involving environment variables defined in the Compose YAML. Something like:
trino:
  environment:
    CONFIG_PROPERTIES: |-
      insights.jdbc.url=jdbc:postgresql://postgres-query-logger:5432/querylogger
      insights.jdbc.user=admin
      insights.jdbc.password=trinoRocks15
      insights.persistence-enabled=true
      insights.metrics-persistence-enabled=true

We'd merge these together based on the presence of configured properties in whatever modules the user wants to provision, then either run an automated script inside the Trino container or mount the collection of properties as a cohesive config.properties file to the container.

We'd want to keep the existing bootstrap functionality around while simultaneously decoupling it from managing this config file.

  1. Remove CLI support for CONFIG and JVM_CONFIG environment variables (see: readme). This is messy and buggy in the first place, and by implementing the 1st request above, there would be little to no need to support these variables.
@jefflester jefflester self-assigned this Apr 24, 2023
@jefflester jefflester added this to the Release 2.0.3 milestone Apr 24, 2023
@jefflester jefflester mentioned this issue Apr 28, 2023
@jefflester
Copy link
Owner Author

Closed with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant