Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merging PRs without tagging a new version #32

Open
jefflinse opened this issue Feb 9, 2022 · 1 comment
Open

Add support for merging PRs without tagging a new version #32

jefflinse opened this issue Feb 9, 2022 · 1 comment
Assignees

Comments

@jefflinse
Copy link
Owner

Instead of always requiring a GitHub version tag (e.g. "major", "minor", "patch", etc) on every pull request, it should be possible for the author to indicate that no new version is to result from merging the pull request.

Proposal

Add a noop-labels configuration variable that accepts a list of label names that, when any are applied to the pull request, will result in no new version being tagged.
a. It is valid to assign more than one label in the noop-labels group to a pull request.
b. It is invalid to assign any label from the noop-labels group and to also assign a label defined by major-label, minor-label, or patch-label.

For example, using the configuration below, users could then label a pull request with documentation change or no new version (or both), causing the pr-semver-bump workflow to complete successfully without tagging any new version.

with:
  noop-labels:
    - documentation change
    - no new version
@benhowes
Copy link

benhowes commented Feb 9, 2022

Currently, I am using no label to signify that I do not want a release, so the only case not mentioned here is what happens when there are no labels on a PR. I probably would migrate to this syntax, but it would require listing nearly all of my labels and keeping that list up-to-date with other changes. I do appreciate this is far more useful for the CI check though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants