Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dontCacheBustUrlsMatching regex shouldn't match domain part? #14

Closed
bgrzys opened this issue Feb 5, 2017 · 1 comment
Closed

dontCacheBustUrlsMatching regex shouldn't match domain part? #14

bgrzys opened this issue Feb 5, 2017 · 1 comment

Comments

@bgrzys
Copy link

bgrzys commented Feb 5, 2017

Hi,
Our main domain is 8 characters long, so it's matching default dontCacheBustUrlsMatching regex: "/.\w{8}./".

My workaround was to restrict this config to "/main.\w{8}./". This works for us, however I believe that proper solution would be to ignore domain part at all. Maybe just use relativeUrl instead of absoluteUrl in createCacheKey? What do you think?

@jeffposnick
Copy link
Owner

Good point. I'll track that at GoogleChromeLabs/sw-precache#240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants