-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with latest create-react-app dependencies #7
Comments
I think your changes do not work with |
Thanks for the heads-up. I haven't had a chance to test this out with (I need a little time to get to it, though.) |
I have react-scripts 0.7.0 as well, and looks like the manifest is getting served with the mime type as text/html. Is there any work around for this? |
I've updated things with an example of using the latest Can you take a look at c-r-a-0.6.0...c-r-pwa-0.6.0 and confirm that making those changes to something scaffolded with the latest |
I've heard from other folks that have confirmed it's working now. Please reopen this issue if you're still seeing issues with |
Thank you @jeffposnick I do not find the time to check it but I will do it soon ;-) As you said other folks confirmed so I trust them ;-) |
I am not sure to understand this sentence in your readme.
When running a production server locally, make sure you use a different port than 3000, to ensure the service worker does not inadvertantly take control of the development environment.
Can we test service workers locally (with classic method
npm start
) with your changes?The text was updated successfully, but these errors were encountered: