Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with latest create-react-app dependencies #7

Closed
camel113 opened this issue Nov 4, 2016 · 6 comments
Closed

Compatibility with latest create-react-app dependencies #7

camel113 opened this issue Nov 4, 2016 · 6 comments

Comments

@camel113
Copy link

camel113 commented Nov 4, 2016

I am not sure to understand this sentence in your readme.
When running a production server locally, make sure you use a different port than 3000, to ensure the service worker does not inadvertantly take control of the development environment.

Can we test service workers locally (with classic method npm start) with your changes?

@camel113
Copy link
Author

camel113 commented Nov 7, 2016

I think your changes do not work with "react-scripts": "0.7.0",

@jeffposnick
Copy link
Owner

Thanks for the heads-up. I haven't had a chance to test this out with react-scripts 0.7.0 yet, and it's entirely possible that the setup needs to be modified. I'll keep this issue open to track that.

(I need a little time to get to it, though.)

@camel113 camel113 changed the title Working locally Compatibility with latest create-react-app dependencies Nov 7, 2016
@nikhildev
Copy link

I have react-scripts 0.7.0 as well, and looks like the manifest is getting served with the mime type as text/html. Is there any work around for this?

@jeffposnick
Copy link
Owner

I've updated things with an example of using the latest create-react-app dependency.

Can you take a look at c-r-a-0.6.0...c-r-pwa-0.6.0 and confirm that making those changes to something scaffolded with the latest create-react-app works for you?

@jeffposnick
Copy link
Owner

I've heard from other folks that have confirmed it's working now. Please reopen this issue if you're still seeing issues with react-scripts 0.7.0.

@camel113
Copy link
Author

Thank you @jeffposnick I do not find the time to check it but I will do it soon ;-) As you said other folks confirmed so I trust them ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants