Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative urls broken #48

Closed
ConorSheehan1 opened this issue Jul 16, 2022 · 2 comments
Closed

Relative urls broken #48

ConorSheehan1 opened this issue Jul 16, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ConorSheehan1
Copy link

relative_url and absolute_url filters are returning weird values for me.

e.g. {{'assets/js/lightbox_custom.js' | absolute_url }} returns https://github.com/pages/ConorSheehan1/assets/js/lightbox_custom.js.
it seems baseurl is somehow https://github.com/pages/ConorSheehan1 when it used to be, and should be https://conorsheehan1.github.io. I'd expect https://conorsheehan1.github.io//assets/js/lightbox_custom.js as the filter output.

I've tried loads of different configs, but my site is completely broken :(
https://github.com/ConorSheehan1/ConorSheehan1.github.io

Any idea how I can fix this?

@ConorSheehan1
Copy link
Author

I finally got it working. Here's the commit that fixed it : ConorSheehan1/ConorSheehan1.github.io@f4558c5

Despite some contradictory advice adding baseurl: "" to _config.yml and using the defaults for this action fixed my build.

@jeffreytse jeffreytse self-assigned this Jul 17, 2022
@jeffreytse jeffreytse added the good first issue Good for newcomers label Jul 17, 2022
@jeffreytse
Copy link
Owner

Hi @ConorSheehan1

It's great to hear that you have fixed this issue. Hope you have a good weekend! : )

Thanks & Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants