Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very minor formatting issue in migration #2

Closed
isimmons opened this issue Feb 19, 2013 · 2 comments
Closed

very minor formatting issue in migration #2

isimmons opened this issue Feb 19, 2013 · 2 comments

Comments

@isimmons
Copy link

line 197 src/commands/GenerateMigrationCommand.php

return implode("\n\t\t\t", $template);

There is a extra tab that only seems to affect the second field, pushing it over too far.

I removed one of them and it all lines up.

@JeffreyWay
Copy link
Owner

I think this is a Windows vs. Mac thing. I need to figure out the best way to handle that.

@isimmons
Copy link
Author

Like I said, it's minor, but has my curiosity up. Is there something with the different LF vs CR+LF causing issue with the TAB or is it just the TAB by it's self causing the issue?

I tried PHP_EOL in place of '\n' just in case but no difference there.

Then I thought why not use PHP_EOL to test the system and return based on that?

    //check if is windows system
    return (PHP_EOL == "\r\n") ? implode("\r\n\t\t", $template) : implode("\n\t\t\t", $template);

vrkansagara referenced this issue in vrkansagara/Laravel-4-Generators Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants