Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel es2015 class uncovered branch #72

Open
darrenmce opened this issue Aug 26, 2016 · 3 comments
Open

babel es2015 class uncovered branch #72

darrenmce opened this issue Aug 26, 2016 · 3 comments

Comments

@darrenmce
Copy link

it seems babel 6.14.0 introduced a new branch when transforming es2015 classes

babel/babel@10cd651

which (i think) results in a newly uncovered branch:
image

not sure where these types of issues are resolved, but I thought it would be worth bringing up here

@darrenmce
Copy link
Author

darrenmce commented Aug 26, 2016

in the mean time, for anyone else, the following pins got my build working without having to lower coverage parameters:

i had to explicitly include babel-plugin-transform-es2015-classes and babel-helper-replace-supers to be able to override the preset's semver

"babel-helper-replace-supers": "6.8.0",
"babel-plugin-transform-es2015-classes": "6.9.0",
"babel-preset-es2015": "6.13.2",

@jeffrifwald
Copy link
Owner

I believe this means the transformer added a branch but did not tell the source map generator about it. 6.14.0 added some checks to classes to allow them to be IE 9/10 compatible, so it is likely the source map is incorrect.

@jeffrifwald
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants