Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khorosjx.users.get_recent_logins() not making verify_core_connection() #1

Closed
jeffshurtliff opened this issue Dec 17, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jeffshurtliff
Copy link
Owner

The khorosjx.users.get_recent_logins() function is missing the function call for verify_core_connection() which can result in the following NameError exception occurring:

Traceback (most recent call last):
  File "recurring/analyze_logins.py", line 50, in get_logins
    login_data = khorosjx.users.get_recent_logins(count, start_index)
  File "/home/shurtj/.local/lib/python3.6/site-packages/khorosjx/users.py", line 338, in get_recent_logins
    query_url = f"{base_url}/people?sort=lastLoggedIn&" + \
NameError: name 'base_url' is not defined
@jeffshurtliff jeffshurtliff added the bug Something isn't working label Dec 17, 2019
@jeffshurtliff jeffshurtliff self-assigned this Dec 17, 2019
@jeffshurtliff
Copy link
Owner Author

A fix for the issue has been deployed in the pre-release version khorosjx-1.6.0.dev0.

@jeffshurtliff
Copy link
Owner Author

Confirmed that the issue is resolved in the stable version khorosjx-1.6.0, as demonstrated below.

>>> login_data = khorosjx.users.get_recent_logins()
>>> login_data[0]['id']
'14845'
>>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant